Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request - log failed login attempts #522

Closed
timmish opened this issue Dec 12, 2023 · 10 comments
Closed

feature request - log failed login attempts #522

timmish opened this issue Dec 12, 2023 · 10 comments
Labels
Done for next release Items that are completed and will be included in the next release Prioritised enhancement High-priority enhancements

Comments

@timmish
Copy link

timmish commented Dec 12, 2023

Hello team,
it would be very nice if StirlingPDF would log the case that someone tried logging in but wasn't successful.
I would love to setup fail2ban inside SWAG for Stirling-PDF.

Thanks you guys for your work.

@Frooodle
Copy link
Member

What would you want the log to show

just failed for IP : x.x.x.x ?

@timmish
Copy link
Author

timmish commented Dec 12, 2023

A timestamp at the beginning of the line, followed by something like “failed login attempt from IP x.x.x.x” would be Perfect.
And it should show the real IP and not the one of the remote proxy - some tools have an extra toggle or setting for that.

Thanks for the quick reply!

@Frooodle Frooodle added the Prioritised enhancement High-priority enhancements label Dec 13, 2023
@Frooodle
Copy link
Member

"And it should show the real IP and not the one of the remote proxy "
This one i am unsure about sorry however i can get the general remote address

@timmish
Copy link
Author

timmish commented Dec 16, 2023

Yeah nice let’s start with that and maybe that already solves it 100% 😄
Have a great weekend!

Frooodle added a commit that referenced this issue Dec 16, 2023
@Frooodle Frooodle added the Done for next release Items that are completed and will be included in the next release label Dec 16, 2023
@Frooodle
Copy link
Member

released in latest 0.17.0!

@Frooodle
Copy link
Member

@timmish please let me know if it works as intended!

@timmish
Copy link
Author

timmish commented Dec 17, 2023

Just tried it and it’s perfect! The IP was the correct one and the extra log folder is an awesome addition, I was working with syslog via the docker extra parameters before.
much appreciated!

@ipod86
Copy link
Contributor

ipod86 commented Aug 17, 2024

@Frooodle
Where is the log so that I can mount it in docker?

@timmish
Can you send me your filter for fail2ban?

@Frooodle
Copy link
Member

All our docker docs show the log folder already you should see it there, /logs

@timmish
Copy link
Author

timmish commented Aug 17, 2024

@ipod86
Site, it is the most basic thing as I have no clue about regex, but it works 😁

`
[Definition]

failregex = IP: <ADDR>
`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Done for next release Items that are completed and will be included in the next release Prioritised enhancement High-priority enhancements
Projects
None yet
Development

No branches or pull requests

3 participants