(Sonar) Fixed finding: "Utility classes should not have public constructors" #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pixeebot[bot]](https://avatars.githubusercontent.com/in/193111?s=60&v=4){kind=small}
|
Frooodle
approved these changes
Jun 7, 2024
pixeebot
bot
deleted the
pixeebot/drip-2024-06-07-sonar-java/avoid-implicit-public-constructor-s1118
branch
szinn
referenced
this pull request
in szinn/k8s-homelab
Jun 9, 2024
…0.25.3 ) (#3802) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/stirling-tools/s-pdf](https://togithub.com/Stirling-Tools/Stirling-PDF) | patch | `0.25.2` -> `0.25.3` | --- ### Release Notes <details> <summary>Stirling-Tools/Stirling-PDF (ghcr.io/stirling-tools/s-pdf)</summary> ### [`v0.25.3`](https://togithub.com/Stirling-Tools/Stirling-PDF/releases/tag/v0.25.3): 0.25.3 fix for version number not showing [Compare Source](https://togithub.com/Stirling-Tools/Stirling-PDF/compare/v0.25.2...v0.25.3) fix for version number not showing #### What's Changed - (Sonar) Fixed finding: "`@Override` should be used on overriding and implementing methods" by [@​pixeebot](https://togithub.com/pixeebot) in [https://github.com/Stirling-Tools/Stirling-PDF/pull/1396](https://togithub.com/Stirling-Tools/Stirling-PDF/pull/1396) - (Sonar) Fixed finding: "Utility classes should not have public constructors" by [@​pixeebot](https://togithub.com/pixeebot) in [https://github.com/Stirling-Tools/Stirling-PDF/pull/1397](https://togithub.com/Stirling-Tools/Stirling-PDF/pull/1397) - 💾 Update Version by [@​github-actions](https://togithub.com/github-actions) in [https://github.com/Stirling-Tools/Stirling-PDF/pull/1399](https://togithub.com/Stirling-Tools/Stirling-PDF/pull/1399) - Enhance Test Coverage for SPDF/Utils Classes by [@​jimdouk](https://togithub.com/jimdouk) in [https://github.com/Stirling-Tools/Stirling-PDF/pull/1385](https://togithub.com/Stirling-Tools/Stirling-PDF/pull/1385) **Full Changelog**: Stirling-Tools/Stirling-PDF@v0.25.2...v0.25.3 </details> <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTkuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM5OS44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL3BhdGNoIl19--> Co-authored-by: repo-jeeves[bot] <106431701+repo-jeeves[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remediation
This change fixes "Utility classes should not have public constructors" (id = java:S1118) identified by Sonar.
Details
This change adds private constructors to utility classes. Utility classes are only meant to be accessed statically. Since they're not meant to be instantiated, we can use the Java's code visibility protections to hide the constructor and prevent unintended or malicious access.
Our changes look something like this:
public class Utils { + private Utils() {} ...More reading
I have additional improvements ready for this repo! If you want to see them, leave the comment:
... and I will open a new PR right away!
🧚🤖 Powered by Pixeebot
💬Feedback | 👥Community | 📚Docs | Codemod ID: sonar:java/avoid-implicit-public-constructor-s1118