[Fix] Handle missing end page in PDF split range #2816
Merged
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the method to handle cases where the end page is not specified (e.g., '1-'). The method now defaults to the last page of the PDF, making the feature more intuitive and preventing ArrayIndexOutOfBoundsException.
Abdurrahman-shaikh
requested review from
Frooodle,
reecebrowne,
Ludy87 and
DarioGii
as code owners
dosubot
bot
added
the
size:XS
Frooodle
approved these changes
Jan 30, 2025
Ludy87
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
What was changed:
handlePartmethod to handle cases where the end page is not specified (e.g., '1-').Why the change was made:
ArrayIndexOutOfBoundsException.Any challenges encountered:
Closes #1576
Checklist
General
Testing