Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect errors raised #790

Closed
13 tasks done
BryanRumsey opened this issue May 3, 2022 · 1 comment · Fixed by #819 or #877
Closed
13 tasks done

Incorrect errors raised #790

BryanRumsey opened this issue May 3, 2022 · 1 comment · Fixed by #819 or #877
Assignees
@BryanRumsey
Labels
bug Something isn't working ✔️​ Issue / PR has been resolved
Milestone
1.7.2 Release

Comments

@BryanRumsey
Copy link
Contributor

BryanRumsey commented May 3, 2022 •
edited
Loading

Events

  • ModelError raised in Event.add_assignment
  • TypeError raised in FunctionDefinition
  • ParameterError raised in Model.add_event
  • ParameterError raised in Model.add_function_definition
  • ParameterError raised in Model.add_rate_rule
  • KeyError raised in Model.delete_assignment_rule
  • KeyError raised in Model.delete_event
  • KeyError raised in Model.delete_function_definition
  • KeyError raised in Model.delete_rate_rule
  • KeyError raised in Model.get_assignment_rule
  • KeyError raised in Model.get_event
  • KeyError raised in Model.get_function_definition
  • KeyError raised in Model.get_rate_rule
@briandrawert briandrawert added this to the 1.6.10 milestone May 23, 2022
@BryanRumsey BryanRumsey linked a pull request Jun 1, 2022 that will close this issue
Updates to model module #819
Merged
@BryanRumsey
Copy link
Contributor Author

Incorrect errors raised in model.py were fixed in #819

@BryanRumsey BryanRumsey modified the milestones: 1.6.10, 1.6.11 Jun 28, 2022
@BryanRumsey BryanRumsey modified the milestones: 1.6.11, 1.7.1 Aug 15, 2022
@BryanRumsey BryanRumsey modified the milestones: 1.7.1, 1.7.2 Oct 5, 2022
@briandrawert briandrawert added the bug Something isn't working label Dec 7, 2022
BryanRumsey added a commit that referenced this issue Dec 8, 2022
@BryanRumsey
Fixed incorrect error in Events. closes #790.
683cd4a
@BryanRumsey BryanRumsey mentioned this issue Dec 8, 2022
Merged
@BryanRumsey BryanRumsey added the ✔️​ Issue / PR has been resolved label Dec 8, 2022
@BryanRumsey BryanRumsey mentioned this issue Dec 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BryanRumsey BryanRumsey

Labels
bug Something isn't working ✔️​ Issue / PR has been resolved
Projects
None yet
Milestone
1.7.2 Release
Development

Successfully merging a pull request may close this issue.

Updates to model module StochSS/GillesPy2
Release v1.7.2 StochSS/GillesPy2
2 participants
@briandrawert @BryanRumsey