HOTFIX: Pause Resume #641
Closed
HOTFIX: Pause Resume #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f the first element.
seanebum
reviewed
Nov 16, 2021
| @@ -331,6 +331,8 @@ def _update_resume_data(self, resume: Results, simulation_data: "list[dict[str, | |||
| for entry_name, entry_data in simulation_data[-1].items(): | |||
| # The results of the current simulation is treated as an "extension" of the resume data. | |||
| # As such, the new simulation output is formed by joining the two end to end. | |||
| if entry_name != "time": | |||
| entry_data = entry_data[:-1] | |||
There was a problem hiding this comment.
I did some testing with pause/resume models, and it showed that there was consistently a duplicate entry from the end time of the initial run to the "next step" of the resume run. This fix shaves the last data point off so that things line up, but I have proposed an alternate fix in #643 which eliminates the duplicate entries.
|
Replaced by #643 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.