Fixed double output from global logger. #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added branch to ensure log handlers can't be installed twice. - Set global logger name to `root` and disabled log propagation.
BryanRumsey
requested changes
Apr 11, 2022
There was a problem hiding this comment.
Double logging still occurs
results = model.run(show_labels=False)
2022-04-11 06:51:28,746 - root - WARNING - show_labels = False is deprecated. Future releases of GillesPy2 may not support this feature.
2022-04-11 06:51:28,746 - root - WARNING - show_labels = False is deprecated. Future releases of GillesPy2 may not support this feature.
|
Double output seems to only occur on OSX environments. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick fix which resolves #761 via the following changes:
gillespy2/core/__init__.pyis evaluated more than once.rootand setlogger.propagatetoFalse. This is the change which ensures that log writes only occur once.