Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Compiler Warning Messages #914

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

briandrawert
Copy link
Member

No description provided.

@briandrawert briandrawert added this to the 1.8.0 Release milestone Jan 6, 2023
@briandrawert briandrawert self-assigned this Jan 6, 2023
@briandrawert briandrawert linked an issue Jan 6, 2023 that may be closed by this pull request
@briandrawert briandrawert marked this pull request as draft January 6, 2023 19:39
@briandrawert briandrawert marked this pull request as ready for review January 6, 2023 19:51
@briandrawert
Copy link
Member Author

To test, in file gillespy2/solvers/cpp/build/make.py add the lines:

         except KeyboardInterrupt:
             log.warning(f"Makefile was interrupted during execution of target: '{target}', unexpected behavior may occur.")

+        print(f"Return code: {result.returncode}"
+              f"- make_cmd: {' '.join(make_cmd)}\n"
+              f"- stdout: {result.stdout.decode('utf-8', errors='ignore')}\n"
+              f"- stderr: {result.stderr.decode('utf-8', errors='ignore')}\n"
+              )
         if result.returncode == 0 and os.path.exists(self.output_file):
             return

Copy link
Collaborator

@jtcooper10 jtcooper10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not only is the delete[] difference a warning, it's undefined behavior on many systems, good fix!

@BryanRumsey BryanRumsey merged commit 680aba7 into develop Feb 7, 2023
@BryanRumsey BryanRumsey mentioned this pull request Feb 9, 2023
@briandrawert briandrawert deleted the cleanup_compiler_warning_messages branch July 25, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup C++ compiler warnings
3 participants