Added debug message to log how much time passes before a predicate happens #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eranco74
approved these changes
Aug 8, 2018
| return | ||
| else: | ||
| time.sleep(interval) | ||
| except: | ||
| time.sleep(interval) | ||
| if predicate(* args, ** kwargs): | ||
| _successful_TS_ASSERT_Count += 1 | ||
| logging.debug("Predicate %s succeed after timeout expired", predicate) |
There was a problem hiding this comment.
Although it's true this log line will be confusing when going over the log (imply failure though counts as success).
Consider changing to:
Predicate %s succeeded just in timeout.
chenyosef
force-pushed
the
chen/add_logging_to_timeout
branch
from
1b115ed to
20b89d5
Compare
spellr
approved these changes
Aug 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help us to detect when test is timed out if it is an unusual timeout or if normally the timeout almost reached, thus need to be extended.
Do you see any harm with this ? is debug level good enough or should it be info ?