feat: Add label to subtitle tracks #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added a check to prevent this: |
kKaskak
approved these changes
Nov 18, 2024
|
Thank you for your contribution! LGTM |
kKaskak
requested changes
Nov 20, 2024
There was a problem hiding this comment.
Actually now looking together with @tymmesyde we suggest some changes:
- Swap places of
track.originandtrack.labelsince the second one is actually more important - If
track.label.startsWith('http')Add a fallback totrack.langfor thelabel - Translate the
track.originif possible (we have translations strings for some cases)
https://github.com/Stremio/stremio-translations/blob/master/en-US.json#L1521
…and handle text overflow for long labels
kKaskak
requested changes
Nov 20, 2024
Co-authored-by: Timothy Z. <[email protected]>
kKaskak
requested changes
Nov 20, 2024
…icialSloth/stremio-web into feat/subtitles-track-label
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to include the subtitle's label below it's origin in the subtitle variant list.
Before:
After:
