Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: modal dialog styles issues #727

Merged
merged 2 commits into from
Nov 16, 2024
Merged

fix: modal dialog styles issues #727

merged 2 commits into from
Nov 16, 2024

Conversation

kKaskak
Copy link
Member

@kKaskak kKaskak commented Nov 16, 2024 •
edited
Loading

Fixes:

  • Content wasn't accessible when the addon info is too long
  • Button text wasn't visible on mobile because of mistake in class placement

@kKaskak kKaskak requested a review from tymmesyde November 16, 2024 20:30
@kKaskak kKaskak linked an issue Nov 16, 2024 that may be closed by this pull request
UX: Long manifest URLs prevent add-on installation button from displaying #721
Closed
@kKaskak kKaskak self-assigned this Nov 16, 2024
@tymmesyde
Copy link
Member

Pushed a commit to rename modal-dialog-content to body-content because it was using the same name as the container

@tymmesyde tymmesyde merged commit 9be4ff2 into development Nov 16, 2024
2 checks passed
@kKaskak kKaskak mentioned this pull request Nov 28, 2024
Closed
@elpiel elpiel deleted the fix/modal-dialog-style-issues branch February 18, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tymmesyde tymmesyde tymmesyde approved these changes

Assignees

@kKaskak kKaskak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UX: Long manifest URLs prevent add-on installation button from displaying
2 participants
@kKaskak @tymmesyde