Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWA: Fix mobile devices style issues #808

Merged
merged 5 commits into from
Jan 23, 2025
Merged

PWA: Fix mobile devices style issues #808

merged 5 commits into from
Jan 23, 2025

Conversation

kKaskak
Copy link
Member

@kKaskak kKaskak commented Jan 23, 2025 •
edited
Loading

  • calendar route in landscape mode didnt follow the app safe inset width
  • navbar was not positioned correctly in PWA mode on iPhone

Tests

https://stremio.github.io/stremio-web/fix/PWA-height-width-global-bugs

  • old iPhone, iPad (iOS 13)
  • old TV test (Samsung, LG)
  • new devices (iPhone PWA, Android PWA)
  • Landscape Fullscreen mode, Portrait Fullscreen mode (Android browsers)

@kKaskak kKaskak added the bug Something isn't working label Jan 23, 2025
@kKaskak kKaskak requested a review from tymmesyde January 23, 2025 14:24
@kKaskak kKaskak self-assigned this Jan 23, 2025
@kKaskak kKaskak added this to the v5.0.0-beta.17 milestone Jan 23, 2025
@kKaskak kKaskak changed the title PWA: Fix iphone style issues PWA: Fix mobile devices style issues Jan 23, 2025
tymmesyde
tymmesyde previously approved these changes Jan 23, 2025
View reviewed changes
@kKaskak kKaskak merged commit 2e45f09 into development Jan 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tymmesyde tymmesyde tymmesyde approved these changes

Assignees

@kKaskak kKaskak

Labels
bug Something isn't working
Projects
None yet
Milestone
v5.0.0-beta.17
Development

Successfully merging this pull request may close these issues.
2 participants
@kKaskak @tymmesyde