Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrading from ibc-go 7.2.0 -> 7.3.1 caused ICQs to fail with the following error
The issue is in
modules/core/23-commitment/types/merkle.go
. Looking at the diff in merkle.go between those releases, we see thatGetKey
no long URL escapes merkle paths.cosmos/ibc-go@v7.2.0...v7.3.1#diff-dd94ec1dde9b047c0cdfba204e30dad74a81de202e3b09ac5b42f493153811afR119
So, we also have to remove url escaping from Stride.
Relevant information from ibc-go: changelog and PR.
Also fixes a typo in the integration tests (@sampocs)
Test plan
Run integration tests