Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed trade route dead code #1189

Merged
merged 14 commits into from
May 14, 2024
Merged

removed trade route dead code #1189

merged 14 commits into from
May 14, 2024

Conversation

sampocs
Copy link
Collaborator

@sampocs sampocs commented May 8, 2024 •
edited
Loading

Context

Now that trades are executed off-chain, the ICA swapping code can be removed.

Brief Changelog

  • Deprecated TradeConfig
  • Deprecated trade_config field in TradeRoute and added min_transfer_amount field (only field from TradeConfig that's still used
  • Deprecated fields in CreateTradeRoute and UpdateTradeRoute txs
  • Updated references of MinSwapAmount to MinTransferAmount
  • Updated txs to not set deprecated fields
  • Removed unused hook entry points
    • SwapAllRewardTokens
    • UpdateAllSwapPrices
  • Removed unused hook business logic
    *SwapRewardTokens
    • TradeRewardBalanceQuery (initiates query of USDC)
    • PoolPriceQuery
    • BuildSwapMsg
  • Removed unused ICQ callbacks
    • PoolPriceCallback
    • TradeRewardBalanceCallback (query of USDC in trade account)
  • Fixed unit tests
  • Added trade route migration

ethan-stride
ethan-stride approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@ethan-stride ethan-stride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
So many lines of code removed. Wow. Much simpler design now

proto/stride/stakeibc/trade_route.proto Show resolved Hide resolved
@sampocs sampocs merged commit 6c53680 into main May 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethan-stride ethan-stride ethan-stride approved these changes

@asalzmann asalzmann Awaiting requested review from asalzmann

@shellvish shellvish Awaiting requested review from shellvish

@riley-stride riley-stride Awaiting requested review from riley-stride

Assignees
No one assigned
Labels
C:app-wiring C:proto C:stakeibc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sampocs @ethan-stride