Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LSM] Scaffolding #706

Merged
merged 13 commits into from
Apr 6, 2023
Merged

[LSM] Scaffolding #706

merged 13 commits into from
Apr 6, 2023

Conversation

sampocs
Copy link
Collaborator

@sampocs sampocs commented Apr 6, 2023

Closes: #XXX

Context and purpose of the change

Brief Changelog

Author's Checklist

I have...

  • Run and PASSED locally all GAIA integration tests
  • If the change is contentful, I either:
    • Added a new unit test OR
    • Added test cases to existing unit tests
  • OR this change is a trivial rework / code cleanup without any test coverage

If skipped any of the tests above, explain.

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • reviewed state machine logic
  • reviewed API design and naming
  • manually tested (if applicable)
  • confirmed the author wrote unit tests for new logic
  • reviewed documentation exists and is accurate

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md?
  • This pull request updates existing proto field values (and require a backend and frontend migration)?
  • Does this pull request change existing proto field names (and require a frontend migration)?
    How is the feature or change documented?
    • not applicable
    • jira ticket XXX
    • specification (x/<module>/spec/)
    • README.md
    • not documented

@mergify
Copy link

mergify bot commented Apr 6, 2023

⚠️ The sha of the head commit of this PR conflicts with #702. Mergify cannot evaluate rules on this PR. ⚠️

@sampocs sampocs changed the title LSM Scaffolding [LSM] Scaffolding Apr 6, 2023
@sampocs sampocs changed the base branch from main to lsm April 6, 2023 15:21
@sampocs sampocs marked this pull request as ready for review April 6, 2023 15:21
Copy link
Contributor

@ethan-stride ethan-stride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall makes sense, only actual error I saw was a few wrong types on params for the keeper functions. Left a few questions on why certain fields or functions are separate as they seem to be repeating other existing fields or functions.

proto/stride/stakeibc/lsm.proto Outdated Show resolved Hide resolved
proto/stride/stakeibc/lsm.proto Show resolved Hide resolved
proto/stride/stakeibc/validator.proto Outdated Show resolved Hide resolved
x/stakeibc/keeper/lsm_token_deposit.go Outdated Show resolved Hide resolved
x/stakeibc/keeper/lsm_token_deposit.go Outdated Show resolved Hide resolved
x/stakeibc/keeper/lsm_token_deposit.go Outdated Show resolved Hide resolved
x/stakeibc/keeper/lsm_token_deposit.go Outdated Show resolved Hide resolved
@sampocs sampocs merged commit 4c35885 into lsm Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants