Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add rounding calibration function #936

Merged
merged 15 commits into from
Sep 18, 2023
Merged

add rounding calibration function #936

merged 15 commits into from
Sep 18, 2023

Conversation

sampocs
Copy link
Collaborator

@sampocs sampocs commented Sep 17, 2023

Closes: #XXX

Context and purpose of the change

Brief Changelog

Author's Checklist

I have...

  • Run and PASSED locally all GAIA integration tests
  • If the change is contentful, I either:
    • Added a new unit test OR
    • Added test cases to existing unit tests
  • OR this change is a trivial rework / code cleanup without any test coverage

If skipped any of the tests above, explain.

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • reviewed state machine logic
  • reviewed API design and naming
  • manually tested (if applicable)
  • confirmed the author wrote unit tests for new logic
  • reviewed documentation exists and is accurate

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md?
  • This pull request updates existing proto field values (and require a backend and frontend migration)?
  • Does this pull request change existing proto field names (and require a frontend migration)?
    How is the feature or change documented?
    • not applicable
    • jira ticket XXX
    • specification (x/<module>/spec/)
    • README.md
    • not documented

@sampocs sampocs changed the base branch from main to ica-undelegate-callback-fix September 17, 2023 05:24
asalzmann
asalzmann reviewed Sep 17, 2023
View reviewed changes
x/stakeibc/client/cli/tx_calibrate_delegation.go Outdated
Short: "Broadcast message calibrate-delegation",
Args: cobra.ExactArgs(2),
RunE: func(cmd *cobra.Command, args []string) (err error) {
argHostdenom := args[0]
Copy link
Contributor

@asalzmann asalzmann Sep 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
argHostdenom := args[0]
argChainId := args[0]

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

asalzmann
asalzmann reviewed Sep 17, 2023
View reviewed changes
x/stakeibc/types/message_calibrate_delegation.go Outdated
return err
}

// basic checks on host denom
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments seem off

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they were just stale from the copy paste - removed

@asalzmann asalzmann changed the base branch from ica-undelegate-callback-fix to main September 18, 2023 04:01
@sampocs sampocs added the A:automerge Automatically merge PR once checks pass label Sep 18, 2023
@mergify mergify bot merged commit 60c18e7 into main Sep 18, 2023
@riley-stride riley-stride mentioned this pull request Oct 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asalzmann asalzmann asalzmann approved these changes

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once checks pass C:CLI C:proto C:stakeibc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sampocs @asalzmann