Do not consider http 304 a request failure #126
Merged
+16
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This status indicates the resource was not modified, rather than being moved. It's used for caching, and considering it a request failure means the server must disable all cache-related headers when rendering for grover.
abrom
requested changes
Aug 26, 2021
There was a problem hiding this comment.
Change looks fine @lucasluitjes although a suggestion RE the spec test
|
Agreed, done. |
|
FYI released in v1.0.4 |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This status indicates the resource was not modified, rather than being moved. It's used for caching, and considering it a request failure means the server must disable all cache-related headers when rendering for grover. That doesn't seem like it would be the purpose of the
raise_on_request_failureoption, so this PR creates an exception for it.