Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3.1 compatibility #147

Merged
merged 4 commits into from
Jan 24, 2022
Merged

Ruby 3.1 compatibility #147

merged 4 commits into from
Jan 24, 2022

Conversation

walski
Copy link
Contributor

@walski walski commented Dec 18, 2021

Ruby 3.1's release is around the corner and grover seems to work just fine with the Ruby 3.1.0-preview1. Specs all pass.

@abrom
Copy link
Contributor

abrom commented Dec 22, 2021

Thanks for the PR @walski 👍

Is there any urgency in applying/releasing this? I'd prefer to have the new Ruby version included in the CI build process before release but that would require the new Ruby version to be released via RVM. Another option would be to include ruby-head in the list of Rubies.. although this would potentially add an air of flake to the CI..

@walski
Copy link
Contributor Author

walski commented Dec 22, 2021

No urgency at all. Just needed it to prepare our app for 3.1 and thought I'd open the PR if the fork is there, already :) Have a great Christmas season and thanks for your work!

Drop Ruby 2.5 support (EOL)
@abrom
Copy link
Contributor

abrom commented Jan 5, 2022

Looks like although RVM does support Ruby 3.1, they haven't included pre-built binaries for it yet. I don't really want to skip using binaries as building from source in CI will take an age.. I'll keep an eye on it and rebuild once the binaries are available 😄

@entretechno-jeremiah
Copy link

Looks like although RVM does support Ruby 3.1, they haven't included pre-built binaries for it yet. I don't really want to skip using binaries as building from source in CI will take an age.. I'll keep an eye on it and rebuild once the binaries are available 😄

Don't hold your breath. They haven't published any binaries in a little over a year now haha. (They have Ruby 3.0.0 but not 3.0.1-3.0.3.)

@akaspick
Copy link
Contributor

@entretechno-jeremiah Yeah, I don't see a 3.1 binary getting released anytime soon via rvm. I think this needs to move ahead without that as plan A and time to look at a plan B.

@walski
Copy link
Contributor Author

walski commented Jan 22, 2022

probably about time to move off Travis

abrom added 2 commits January 24, 2022 16:12
(which will at least give us a 3.1 build)
@abrom
Copy link
Contributor

abrom commented Jan 24, 2022

I've updated it to use ruby-head which was last built in the Travis RVM mirror at the end of the year (so is going to be pretty close to the 3.1 release).

Yes, I agree.. moving away from Travis is on my TODO list

@abrom abrom merged commit d311a4c into Studiosity:main Jan 24, 2022
@abrom
Copy link
Contributor

abrom commented Jan 24, 2022

Released as v1.1.1

@walski
Copy link
Contributor Author

walski commented Jan 24, 2022

🙏 thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants