Scrub the middleware cover page request env before request #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrom
force-pushed
the
scrub-cover-page-env
branch
from
4f40fb2 to
617c142
Compare
|
FYI @jnimety I've tested it locally and the fix works fine for me. Would you mind verifying that this branch resolves the issue for your configuration too If it works as expected I'll release a build |
|
I'll test tomorrow morning, thanks again for the quick turnaround. |
|
Works fine for me as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue raised in #40
The original request env was adding cached parameters resulting in the cover page requests using the cache instead of generating the params themselves. This change scrubs the env before calling to the app when generating the cover page. The method used was pulled out of the ActionController TestCase class so should give us reasonable expectations over what needs to be cleaned up between requests.