Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change how feedforward works #71

Merged
merged 3 commits into from
Jan 25, 2023
Merged

Change how feedforward works #71

merged 3 commits into from
Jan 25, 2023

Conversation

selym3
Copy link
Collaborator

@selym3 selym3 commented Jan 25, 2023

  • remove feedforward and its subclasses
  • create MotorFeedforward with .position, .velocity, .angle
  • create ElevatorFeedforward, AngleFeedforward to account for additional terms
  • adjust classes to still work with MotorFeedforward

@selym3 selym3 merged commit d495b36 into main Jan 25, 2023
@selym3 selym3 deleted the mp/controls-new-feedforward branch January 25, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sam-Belliveau Sam-Belliveau Sam-Belliveau approved these changes

@vincentw921 vincentw921 Awaiting requested review from vincentw921

@anivanchen anivanchen Awaiting requested review from anivanchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@selym3 @Sam-Belliveau