fix disabled button color #1184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 18, 2020
the-j0k3r
commented
Jul 21, 2020
| body[class="page-responsive"] .btn-primary .octicon { | ||
| color: hsla(0, 0%, 100%, .8); | ||
| color: hsla(0, 0%, 100%, .3); |
There was a problem hiding this comment.
Here at this value the octicon is going to break because $color thinks this is OK. SO we fix one and break others.
the-j0k3r
commented
Jul 21, 2020
| .btn-primary .octicon { | ||
| color: hsla(0, 0%, 100%, .8); | ||
| color: hsla(0, 0%, 100%, .3); |
| .section-codespaces-develop-night .codespaces-develop-text { | ||
| color: hsla(0, 0%, 100%, .8) !important; | ||
| color: hsla(0, 0%, 100%, .3) !important; |
| .flash-header { | ||
| color: hsla(0, 0%, 100%, .8); | ||
| color: hsla(0, 0%, 100%, .3); |
| html[class^="ghh"] .ghh button.ghh-aux { | ||
| color: hsla(0, 0%, 100%, .8); | ||
| color: hsla(0, 0%, 100%, .3); |
| @@ -34687,9 +34687,9 @@ | |||
| .cpt-notification { | |||
| color: #fff; | |||
| } | |||
| /* githubstatus.com: "rgba(255,255,255,0.8)" */ | |||
| /* githubstatus.com: "color: hsla(0,0%,100%,.8)" */ | |||
| .layout-content.status.status-index .page-status .last-updated-stamp { | ||
| color: hsla(0, 0%, 100%, .8); | ||
| color: hsla(0, 0%, 100%, .3); |
|
The main issue here is that a inversion approach does not cleanly work because GH uses white text and we do too (ideally we should have black text but that won't work either). I see no good solution except to manually override the disabled button selectors unfortunately. |
silverwind
added a commit
that referenced
this pull request
Jul 21, 2020
|
Ideally we wouldnt fix what isnt broken, buttons use to work and already manual styles, it seems like were going backwards here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how a disabled button looks,
Looks anything BUT.
re: #1154 issue 2
The reason why I PR this is for @silverwind to see how using
$colorfor buttons is less than ideal idea because whats good in one value for some property in a rule elsewhere isnt necessarily good for another rule with a different property, in this case this PR is good for disabled button text color but not good for other rules.Read the diff and see the wack-a-mole game
I cant commit this in good conscience and manual fixes at this level is not something I want to revisit.