Reduce progress update interval to 0.1 #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm using an old MBP (Early 2015) and I noticed very high CPU usage while playing music (~50%). With this PR, the CPU usage drops to ~7% while playing. |
|
Looks like I ran the numbers before a year ago almost to this day. I reverted back to the 0.01 NSTimer instead of using KVO, but did notice that a 0.1 timer took less CPU time. I just don't remember why I didn't apply that change afterward. |
|
Oh, I think it might have been the sliders not adjusting constantly smoothly. I don't think it matters that much though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This significantly reduces CPU usage.