Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor: RainbowGrades] Academic sanction #61

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Conversation

RitaLei123
Copy link
Contributor

@RitaLei123 RitaLei123 commented Sep 30, 2023

Closes Submitty/Submitty#9725
Changed all the mossify and moss instances to academic_sanction in three documents (main.cpp, student.cpp, student.h) in the Rainbow Grades directory. These changes were made to avoid potential copyright issues.

image

@RitaLei123 RitaLei123 requested a review from ziesski September 30, 2023 02:24
@RitaLei123 RitaLei123 assigned RitaLei123 and unassigned RitaLei123 Sep 30, 2023
Copy link
Member

@ziesski ziesski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you changed moss -> academic_sanction as well, but there are some files that you have missed, and it will not compile correctly. For example check output.cpp line 949 still has getmosspenalty. Please be more careful when replacing terms, as it may be used more broadly.

@RitaLei123
Copy link
Contributor Author

I see you changed moss -> academic_sanction as well, but there are some files that you have missed, and it will not compile correctly. For example check output.cpp line 949 still has getmosspenalty. Please be more careful when replacing terms, as it may be used more broadly.

@RitaLei123 RitaLei123 closed this Oct 2, 2023
@RitaLei123 RitaLei123 reopened this Oct 2, 2023
@RitaLei123
Copy link
Contributor Author

I see you changed moss -> academic_sanction as well, but there are some files that you have missed, and it will not compile correctly. For example check output.cpp line 949 still has getmosspenalty. Please be more careful when replacing terms, as it may be used more broadly.

image

I have fixed those all the cases and doubled checked everything. There should be no more moss instances now. Sorry, I will be more careful in the future.

@RitaLei123 RitaLei123 requested a review from ziesski October 2, 2023 07:45
@RitaLei123 RitaLei123 linked an issue Oct 6, 2023 that may be closed by this pull request
Copy link
Member

@ziesski ziesski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, I reviewed the code, and also tested locally.
One thing to comment is we have student.cpp patch going on, so I think we should merge this after the patch gets merged to reduce merge conflict.

@bmcutler bmcutler merged commit db9d68d into main Nov 7, 2023
@bmcutler bmcutler deleted the academic_sanction branch November 7, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace mossify to academic sanction
3 participants