-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor: RainbowGrades] Academic sanction #61
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you changed moss -> academic_sanction as well, but there are some files that you have missed, and it will not compile correctly. For example check output.cpp line 949 still has getmosspenalty. Please be more careful when replacing terms, as it may be used more broadly.
Missed two files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, I reviewed the code, and also tested locally.
One thing to comment is we have student.cpp patch going on, so I think we should merge this after the patch gets merged to reduce merge conflict.
Closes Submitty/Submitty#9725
Changed all the mossify and moss instances to academic_sanction in three documents (main.cpp, student.cpp, student.h) in the Rainbow Grades directory. These changes were made to avoid potential copyright issues.