Skip to content
This repository has been archived by the owner on Oct 18, 2021. It is now read-only.

Support NestedMapping and MultiFieldsMapping in Release 2.0.8.1 #163

Merged
merged 2 commits into from
Jun 29, 2018

Conversation

CCheSumo
Copy link
Contributor

@CCheSumo CCheSumo commented Jun 28, 2018

We haven't moved elastic-client to 6.x in metrics. Plan is to do that next quarter. Meanwhile, we will need to support nested mapping and multi-fields mapping. I am adding this change to this branch only atm. I will create a 2.0.9 branch for publishing after all functionalities has been included.

I am also adding a issue #164 to cherry-pick changes here to the latest master.

@codecov-io
Copy link

codecov-io commented Jun 28, 2018

Codecov Report

Merging #163 into release-2.0.8 will increase coverage by 0.23%.
The diff coverage is 68.75%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             release-2.0.8     #163      +/-   ##
===================================================
+ Coverage            60.87%   61.11%   +0.23%     
  Complexity              88       88              
===================================================
  Files                   14       14              
  Lines                  961      972      +11     
  Branches               236      238       +2     
===================================================
+ Hits                   585      594       +9     
  Misses                 218      218              
- Partials               158      160       +2
Impacted Files Coverage Δ Complexity Δ
...ogic/elasticsearch/restlastic/dsl/MappingDsl.scala 49.03% <68.75%> (+3.87%) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f7f891...997c8f7. Read the comment docs.

@CCheSumo CCheSumo requested review from wojciechatsumo and rcoh June 28, 2018 22:04
@CCheSumo CCheSumo changed the title Release 2.0.8.1 Support NestedMapping and MultiFieldsMapping in Release 2.0.8.1 Jun 28, 2018
@CCheSumo CCheSumo requested a review from lchodar June 28, 2018 22:10
Copy link
Contributor

@wojciechatsumo wojciechatsumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I was about to introduce similar changes, nice that you got it before I even started! :)

@CCheSumo CCheSumo merged commit be1a829 into release-2.0.8 Jun 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants