-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to add custom fields via config #56
Allow to add custom fields via config #56
Conversation
Expose `custom_fields` configuration parameter, which is going to be merged with record's fields. Example: ```ruby record[:fields] = "foo=bar" custom_fields = "lorem=ipsum" ``` is going to generate ```ruby headers['X-Sumo-Fields']='foo=bar,lorem=ipsum' ```
@samjsong Could you take care about reviewers? I don't have permissions for this repo :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lib/fluent/plugin/out_sumologic.rb
Outdated
@@ -86,6 +86,9 @@ class Fluent::Plugin::Sumologic < Fluent::Plugin::Output | |||
config_param :timestamp_key, :string, :default => 'timestamp' | |||
config_param :proxy_uri, :string, :default => nil | |||
config_param :disable_cookies, :bool, :default => false | |||
# https://help.sumologic.com/Manage/Fields | |||
desc 'Fields string (eg "a=b,c=d") which is going to be added to every record.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could have used a better example
e.g cluster=payment, service=credit_card
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, will do that
Expose
custom_fields
configuration parameter, which is goingto be merged with record's fields.
Example:
is going to generate