feat(max_request_size): add max_request_size to limit size of requests #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
reviewed
Apr 21, 2022
swiatekm
reviewed
Apr 21, 2022
test/plugin/test_out_sumologic.rb
Outdated
Comment on lines
920
to
925
| endpoint #{endpoint} | ||
| records_per_request -5 | ||
| }, | ||
| %{ | ||
| endpoint #{endpoint} | ||
| records_per_request 0 |
There was a problem hiding this comment.
You should update this to use max_request_size instead.
swiatekm
approved these changes
Apr 21, 2022
sumo-drosiek
changed the title
sumo-drosiek
force-pushed
the
drosiek-split-request
branch
from
65c738a to
73457bf
Compare
sumo-drosiek
changed the title
sumo-drosiek
commented
Apr 22, 2022
sumo-drosiek
commented
Apr 22, 2022
andrzej-stencel
approved these changes
Apr 22, 2022
… records per request Signed-off-by: Dominik Rosiek <[email protected]>
sumo-drosiek
force-pushed
the
drosiek-split-request
branch
from
ece48e2 to
e318625
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds records_per_request on the top of retry changes. This is going to limit maximum number of records in request. This is because for bigger chunks, there is possibility to get send_timeout because of cancelling the request by receiver