Skip to content

Commit

Permalink
Don't use race detector for jobreceiver tests (#1639)
Browse files Browse the repository at this point in the history
This commit overrides the race detection in the jobreceiver tests. While
this prevents us from catching data races in the jobreceiver in CI, it
also keeps CI from failing sporadically on Darwin.

There's something amiss in the jobreceiver tests and it causes CI to
fail quite regularly, almost always on Darwin. I suspect there is some
concurrency bug in the test harness that is more likely to deadlock when
the race detector is enabled. (The race detector slows everything down,
and that can make deadlocks more likely to happen by exposing timing
bugs).

Signed-off-by: Eric Chlebek <[email protected]>
  • Loading branch information
echlebek authored Jul 26, 2024
1 parent 35dcf13 commit bd34f70
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions pkg/receiver/jobreceiver/Makefile
Original file line number Diff line number Diff line change
@@ -1 +1,9 @@
include ../../Makefile.Common

# override test command for this package so the race detector doesn't run.
# the tests are flaky on Darwin, timing out after 10 minutes, and it's likely
# due to a concurrency bug interacting with the race detector in the test
# harness.
.PHONY: test
test:
go test ./...

0 comments on commit bd34f70

Please sign in to comment.