Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add otelcol-config #1607

Merged
merged 19 commits into from
Jul 9, 2024
Merged

Add otelcol-config #1607

merged 19 commits into from
Jul 9, 2024

Conversation

echlebek
Copy link
Collaborator

@echlebek echlebek commented Jun 20, 2024

This commit adds otelcol-config, a tool designed to be used for configuration otelcol-sumo installations.

The tool will mainly write values to conf.d/00-otelcol-config-settings.yaml, conf.d/99-otelcol-config-overrides.yaml, and link and unlink specific configuration files in conf.d from conf.d/available.

This commit adds otelcol-config, a tool designed to be used for
configuration otelcol-sumo installations.

The tool will mainly write values to sumologic.yaml, and link and
unlink files in conf.d.

Signed-off-by: Eric Chlebek <[email protected]>
@echlebek echlebek self-assigned this Jun 20, 2024
@echlebek echlebek requested a review from a team as a code owner June 20, 2024 17:10
@echlebek echlebek marked this pull request as draft June 20, 2024 17:12
echlebek added 2 commits June 20, 2024 10:17
Signed-off-by: Eric Chlebek <[email protected]>
Signed-off-by: Eric Chlebek <[email protected]>
@sumo-drosiek
Copy link
Contributor

Awesome! Do we consider to move other functionality from the install script as well? (checking otel version, verifying what is the latest one and so on?)

@swiatekm
Copy link

Shouldn't this live in the packaging repo?

@amdprophet
Copy link
Contributor

Awesome! Do we consider to move other functionality from the install script as well? (checking otel version, verifying what is the latest one and so on?)

I think this falls outside of the existing scope of otelcol-config. We're moving away from using curl in the shell script all together and instead will be using packaging repositories where the latest version can be determined from package managers (e.g. yum/dnf, apt, etc.)

Shouldn't this live in the packaging repo?

The otelcol-config binary will be packaged with the otelcol-sumo binary. Its features are tightly coupled with the features of otelcol-sumo. I believe it's best to keep it in the collector repository as a result and use the same versioning as the otelcol-sumo binary.

echlebek added 11 commits June 26, 2024 15:03
And not sumologic.yaml!

Signed-off-by: Eric Chlebek <[email protected]>
Adds a function that reads configuration out of a defined directory
structure and represents it as raw bytes.

Signed-off-by: Eric Chlebek <[email protected]>
Signed-off-by: Eric Chlebek <[email protected]>
Instead of get-kv, set-kv, del-kv, and append-kv, it's sufficient to
have just read-kv and write-kv actions. write-kv can do everything
necessary for deleting and appending values.

Signed-off-by: Eric Chlebek <[email protected]>
Signed-off-by: Eric Chlebek <[email protected]>
Signed-off-by: Eric Chlebek <[email protected]>
Signed-off-by: Eric Chlebek <[email protected]>
Signed-off-by: Eric Chlebek <[email protected]>
@echlebek echlebek changed the title Add otelcol-config skeleton Add otelcol-config Jul 7, 2024
@echlebek echlebek marked this pull request as ready for review July 7, 2024 07:48
@echlebek echlebek enabled auto-merge (squash) July 9, 2024 19:14
@echlebek echlebek merged commit 9214063 into main Jul 9, 2024
24 checks passed
@echlebek echlebek deleted the otelcol-config branch July 9, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants