-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issueid #232821 fix: Unexpected API Call: /pointer/getPoints/43477152… #248
Issueid #232821 fix: Unexpected API Call: /pointer/getPoints/43477152… #248
Conversation
…29 Triggered When Not Required
Caution Review failedThe pull request is closed. Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
src/components/Assesment/Assesment.jsxOops! Something went wrong! :( ESLint: 7.32.0 ESLint couldn't find the config "react-app" to extend from. Please check that the name of the config is correct. The config "react-app" was referenced from the config file in "/package.json". If you still have problems, please stop by https://eslint.org/chat/help to chat with the team. WalkthroughThe pull request introduces a consistent approach to conditionally fetching pointer details across multiple components. The changes focus on preventing unnecessary API calls when the application is running within an iframe context. By adding a conditional check using the environment variable Changes
Sequence DiagramsequenceDiagram
participant App
participant Environment
participant API
App->>Environment: Check REACT_APP_IS_APP_IFRAME
alt Not in iframe
App->>API: Fetch Pointer Details
API-->>App: Return Pointer Details
else In iframe
App->>App: Skip Pointer Details Fetch
end
Possibly related PRs
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
7795733
into
Sunbird-ALL:all-1.3-feedback-change
…29 Triggered When Not Required
Summary by CodeRabbit
Bug Fixes
Chores