-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SB-27408 | Assessment archival to update existing requests #499
Open
kumarks1122
wants to merge
25
commits into
Sunbird-Ed:release-4.5.0
Choose a base branch
from
kumarks1122:release-4.5.0-archival-changes
base: release-4.5.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
SB-27408 | Assessment archival to update existing requests #499
kumarks1122
wants to merge
25
commits into
Sunbird-Ed:release-4.5.0
from
kumarks1122:release-4.5.0-archival-changes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…factor-changes Assessment archival refactor changes
manjudr
requested changes
Dec 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kumarks1122 @utk14 - Plase make the code changes -
- In the subclass, define the archival format; each job has its own archival format.
- Do not include archiving logic in the base class. Allow the subclass to implement, and the base class should take the archival status and update the database.
- Remove any logs that are no longer required.
- Eliminate hardcoding the year and week number. For example, (how do we do it here if I only want to archive for a year and a month?)
data-products/src/main/scala/org/sunbird/analytics/archival/BaseArchivalJob.scala
Outdated
Show resolved
Hide resolved
data-products/src/main/scala/org/sunbird/analytics/archival/BaseArchivalJob.scala
Outdated
Show resolved
Hide resolved
data-products/src/main/scala/org/sunbird/analytics/archival/BaseArchivalJob.scala
Outdated
Show resolved
Hide resolved
data-products/src/main/scala/org/sunbird/analytics/archival/BaseArchivalJob.scala
Outdated
Show resolved
Hide resolved
data-products/src/main/scala/org/sunbird/analytics/archival/BaseArchivalJob.scala
Outdated
Show resolved
Hide resolved
manjudr
requested changes
Dec 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary.
- week and year is hardcoded in the base class and metastore class.
- Please remove the unwanted logs and printing dataframes.
- Please add a filter logic to filter the collection type (course/survey etc.)
data-products/src/main/scala/org/sunbird/analytics/archival/AssessmentArchivalJob.scala
Outdated
Show resolved
Hide resolved
data-products/src/main/scala/org/sunbird/analytics/archival/AssessmentArchivalJob.scala
Outdated
Show resolved
Hide resolved
data-products/src/main/scala/org/sunbird/analytics/archival/AssessmentArchivalJob.scala
Outdated
Show resolved
Hide resolved
data-products/src/main/scala/org/sunbird/analytics/archival/AssessmentArchivalJob.scala
Outdated
Show resolved
Hide resolved
data-products/src/main/scala/org/sunbird/analytics/archival/BaseArchivalJob.scala
Outdated
Show resolved
Hide resolved
data-products/src/main/scala/org/sunbird/analytics/archival/util/ArchivalMetaDataStoreJob.scala
Outdated
Show resolved
Hide resolved
data-products/src/main/scala/org/sunbird/analytics/archival/util/ArchivalMetaDataStoreJob.scala
Outdated
Show resolved
Hide resolved
data-products/src/main/scala/org/sunbird/analytics/archival/util/ArchivalMetaDataStoreJob.scala
Outdated
Show resolved
Hide resolved
data-products/src/main/scala/org/sunbird/analytics/archival/util/ArchivalMetaDataStoreJob.scala
Outdated
Show resolved
Hide resolved
data-products/src/main/scala/org/sunbird/analytics/archival/BaseArchivalJob.scala
Outdated
Show resolved
Hide resolved
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please choose appropriate options.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes in the below checkboxes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: