Issue #SB-0000 feat : Implementation of Play - Pause and Normal screen for Interactive Content. #104
Conversation
…n for Interactive Content.
| @Input() config: any; | ||
| @Input() action: string; |
There was a problem hiding this comment.
Can we make this an interface with action name and other properties,
Example:
Tomorrow if we get a use case like play from 1:45 min if answered all questions in question set or play from 1:10 min if unanswered
Also, please update the documents both README and microsite and add the unit test cases for the same/
There was a problem hiding this comment.
We have changed it to a property in an Interface , updated readme but I dont have access to microsite
| @@ -217,6 +219,11 @@ export class SunbirdVideoPlayerComponent implements OnInit, AfterViewInit, OnDes | |||
| } | |||
| this.videoInstance.play(); | |||
| this.videoInstance.controls(true); | |||
| // if currently video is not in full screen and was previously full screen then set it back to full screen again | |||
There was a problem hiding this comment.
Can you write the test cases for the same and it should not break existing flows in the portal and mobile apps, Can you confirm same?
There was a problem hiding this comment.
In the mobile the Interactive Video is played in the landscape mode only so the fullscreen issue does not arise
There was a problem hiding this comment.
Mobile app planning to implement portrait mode also, So keep that scenario also covered
There was a problem hiding this comment.
Sunbird-Ed/Community#15
We previously had a discussion with the mobile team to open Interactive video in landscape mode only
There was a problem hiding this comment.
Videos (without Interactive content / QuestionSet) can be played in both portrait and landscape mode.
But QuestionSet in the mobile app in portrait is not showing properly so whenever we have
Interactive video having Questionset in it that is handled my mobile team to play it in landscape mode.
Sunbird-Ed/SunbirdEd-mobile-app#3016
| @@ -1,8 +1,12 @@ | |||
| <div class="player-grid"> | |||
| <div> | |||
| <div class="aspectratio" data-ratio="16:9" id="help-video-aspect-ratio" #aspectRatio> | |||
| <sunbird-video-player *ngIf="playerConfig" [playerConfig]="playerConfig" (playerEvent)="playerEvent($event)" (telemetryEvent)="telemetryEvent($event)"></sunbird-video-player> | |||
| </div> | |||
| <sunbird-video-player *ngIf="playerConfig" [playerConfig]="playerConfig" (playerEvent)="playerEvent($event)" (telemetryEvent)="telemetryEvent($event)" [action]="action"></sunbird-video-player> | |||
There was a problem hiding this comment.
Make action an optional input field
There was a problem hiding this comment.
We have handled it in the sunbird-video-player.component.ts and video-player.component.ts
…ideo-player into release-4.10.0
|
@Xitija Still the README file is out of date with your changes, Please update it |
| @@ -217,6 +219,11 @@ export class SunbirdVideoPlayerComponent implements OnInit, AfterViewInit, OnDes | |||
| } | |||
| this.videoInstance.play(); | |||
| this.videoInstance.controls(true); | |||
| // if currently video is not in full screen and was previously full screen then set it back to full screen again | |||
There was a problem hiding this comment.
Mobile app planning to implement portrait mode also, So keep that scenario also covered
| @@ -1,11 +1,11 @@ | |||
| { | |||
| "name": "@project-sunbird/sunbird-video-player-v9", | |||
| "version": "4.10.2", | |||
There was a problem hiding this comment.
Please change version to 5.0.1
Updated player version
|
Kudos, SonarCloud Quality Gate passed!
|
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please choose appropriate options.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes in the below checkboxes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: