IQ-125 Modified Review flow for observation/survey #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krgauraw
suggested changes
Feb 1, 2024
assessment-api/assessment-service/app/controllers/v5/QuestionSetController.scala
Outdated
Show resolved
Hide resolved
assessment-api/assessment-service/app/controllers/v4/QuestionSetController.scala
Outdated
Show resolved
Hide resolved
assessment-api/assessment-actors/src/main/scala/org/sunbird/actors/QuestionSetActor.scala
Outdated
Show resolved
Hide resolved
assessment-api/assessment-actors/src/main/scala/org/sunbird/actors/QuestionSetActor.scala
Show resolved
Hide resolved
| throw new ClientException(errCode, "Comment key is missing or value is empty in the request body.") | ||
| } else { | ||
| val readReq = request | ||
| readReq.put("identifier", identifier) |
There was a problem hiding this comment.
please add mode=edit in the read request . so that you system will fetch latest node.
assessment-api/assessment-actors/src/main/scala/org/sunbird/v5/actors/QuestionSetActor.scala
Outdated
Show resolved
Hide resolved
assessment-api/assessment-actors/src/main/scala/org/sunbird/v5/actors/QuestionSetActor.scala
Show resolved
Hide resolved
| throw new ClientException(errCode, "Comment key is missing or value is empty in the request body.") | ||
| } else { | ||
| val readReq = request | ||
| readReq.put("identifier", identifier) |
There was a problem hiding this comment.
please add mode=edit in the read request . so that you system will fetch latest node.
...sment-api/assessment-actors/src/main/scala/org/sunbird/v5/managers/AssessmentV5Manager.scala
Outdated
Show resolved
Hide resolved
krgauraw
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@krgauraw
Design doc approved by DC - https://project-sunbird.atlassian.net/l/cp/HDuR6Nmz
Story - https://project-sunbird.atlassian.net/browse/IQ-125
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please choose appropriate options.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes in the below checkboxes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: