-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asymmetric correlations (continued from #174 ) #217
Conversation
Some tests are still erroring and requires more investigation
This reverts commit 8b2cc8b.
also updates and upgrades the correlation tests
More specifically, this averages over i and sums over j, instead of summing over both i and j.
@@ -266,6 +266,7 @@ function step!(sys::System{0}, integrator::ImplicitMidpoint) | |||
|
|||
s = sys.dipoles | |||
(; Δt, atol) = integrator | |||
isnan(Δt) && return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check is already made in check_timestep_available()
above.
460cb7d
to
8470f52
Compare
Here is a list of what this PR adds/changes (can be condensed into some
|
#237 includes points (1) (2) (7b) (7c, sort of) and (9) from the above list |
This feature is currently out of scope, but can be revisited if there is sufficient user demand. |
This is #174 but fixed up and rebased onto modern Sunny