Undeprecate biquad argument in set_exchange!
#279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since scalar-biquadratic is such a common use case, this PR uniformly supports again it with the
biquadargument toset_exchange!, regardless of mode.I was originally hoping we could entirely remove the$S \to \infty$ ) in the tensor product space along a bond. It would be complicated to implement, and there is not a strong motivation, especially since we are de-emphasizing
biquadargument, and instead direct people to the more generalset_pair_coupling!function. That idea hit a snag withmode = :dipole_large_S. In particular, Sunny doesn't have a way to represent symbolic spin operators (:dipole_large_S.Fixes #276.