Skip to content

Commit

Permalink
Fix `disable_test_id_escaping_and_forfeit_all_rights_to_community_sup…
Browse files Browse the repository at this point in the history
…port` option when using a list of test IDs
  • Loading branch information
akiomik authored and Sup3rGeo committed May 30, 2019
1 parent daff371 commit 3f0bb1e
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ Abhijeet Kasurde
Adam Johnson
Adam Uhlir
Ahn Ki-Wook
Akiomi Kamakura
Alan Velasco
Alexander Johnson
Alexei Kozlenok
Expand Down
1 change: 1 addition & 0 deletions changelog/5286.bugfix.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix issue with ``disable_test_id_escaping_and_forfeit_all_rights_to_community_support`` option doesn't work when using a list of test IDs in parametrized tests.
2 changes: 1 addition & 1 deletion src/_pytest/python.py
Original file line number Diff line number Diff line change
Expand Up @@ -1217,7 +1217,7 @@ def _idvalset(idx, parameterset, argnames, idfn, ids, item, config):
]
return "-".join(this_id)
else:
return ascii_escaped(ids[idx])
return _ascii_escaped_by_config(ids[idx], config)


def idmaker(argnames, parametersets, idfn=None, ids=None, config=None, item=None):
Expand Down

0 comments on commit 3f0bb1e

Please sign in to comment.