Add more customisation on helm-chart #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hipska
requested changes
Oct 20, 2022
|
If its more simple fore you, reject the PR and focus your time on the docker images. |
|
No it is fine for me to update the helm chart, I just want to be sure about some choices as I'm not familiar with Helm / Kubernetes. |
Hipska
reviewed
Oct 21, 2022
finaldzn
reviewed
Oct 21, 2022
Hipska
reviewed
Oct 24, 2022
Hipska
approved these changes
Oct 24, 2022
Hipska
approved these changes
Oct 24, 2022
Hipska
approved these changes
Oct 25, 2022
There was a problem hiding this comment.
All looks good! Many thanks.
PS: You are welcome to join the iTop Slack where you can meet iTop developers and users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
We have deployed iTOP on our kubernetes cluster and here is the modifications we did.
There is, more customisation and default apache port customisation possibility.
I did a little change on the dockerfile to include port customisation (not in this PR, if you want it I'll push it)