Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build pxtools with elastix #33

Closed
kaspermarstal opened this issue Oct 12, 2017 · 8 comments
Closed

Build pxtools with elastix #33

kaspermarstal opened this issue Oct 12, 2017 · 8 comments
Assignees
@mstaring
Labels
bug

Comments

@kaspermarstal
Copy link
Member

Tests currently depends on pxtools which have to be installed separately. This is a problem for CI, where some tests always fail, and for users who want to run tests.
@mstaring
Copy link
Member

ca2db47

should fix this dependency

@mstaring
Copy link
Member

@kaspermarstal can you check if CI now works properly?

@kaspermarstal
Copy link
Member Author

I am afraid it doesn't. It fails with AttributeError: 'module' object has no attribute 'replace'. Closer though! Looks like the overlap exe is working.

@mstaring
Copy link
Member

this function is available since python 3.3
What version is on CI?

@kaspermarstal
Copy link
Member Author

kaspermarstal commented Oct 16, 2017 •
edited
Loading

Looks like python 2.7.

kaspermarstal added a commit that referenced this issue Oct 16, 2017
@kaspermarstal
CI: Use the shutil equivalent of os.rename() and is.replace() which i…
20a1318 
…s available in Python 2.7 #33
@mstaring
Copy link
Member

d34e7f9

@mstaring
Copy link
Member

lets wait and see if appveyor is green

mstaring added a commit that referenced this issue Jan 3, 2018
@mstaring
Elx 34 remove testing external dependencies (#39)
2577adc 
* CI: Use the shutil equivalent of os.rename() and is.replace() which is available in Python 2.7 #33

* COMP: making sure python move operations work

Also with python 2.7.

* BUG: check for file existence

* COMP: copy paste error

* CI: Compile all components on AppVeyor

* CI: Touching appveyor.yml to trigger rebuild

* CI: Build ITK and elastix separately on AppVeyor to avoid build time limit

* CI: Fix AppVeyor script

* CI: Fix AppVeyor cache stamp
@mstaring
Copy link
Member

fixed

@schmiedc schmiedc mentioned this issue Nov 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mstaring mstaring

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kaspermarstal @mstaring