Overwrite server.conf settings only for provided env vars #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schroda
force-pushed
the
feature/overwrite_server_config_settings_with_env_vars_only_if_var_is_set
branch
3 times, most recently
from
dacb220 to
0ea2555
Compare
Syer10
requested changes
Jan 20, 2024
Currently on every start the whole server.conf file gets replaced which causes any changed settings during runtime to get lost
This is the only setting that can not be changed via the UI
chancez
reviewed
Jan 20, 2024
| #!/bin/bash | ||
|
|
||
| # exit early in case the file already exists | ||
| if [ -f /home/suwayomi/.local/share/Tachidesk/server.conf ]; then |
There was a problem hiding this comment.
This means the file will not get updated even if you change env-vars, which feels sort of confusing.
There was a problem hiding this comment.
It will, this script just creates the config for the first time, its not used after that
schroda
force-pushed
the
feature/overwrite_server_config_settings_with_env_vars_only_if_var_is_set
branch
from
0ea2555 to
e0c6e8b
Compare
schroda
deleted the
feature/overwrite_server_config_settings_with_env_vars_only_if_var_is_set
branch
|
I think it would still be useful to have a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on every start the whole server.conf file gets replaced which causes any changed settings during runtime to get lost
closes #63