Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup directory names #251

Merged
merged 1 commit into from
Nov 15, 2021
Merged

cleanup directory names #251

merged 1 commit into from
Nov 15, 2021

Conversation

AriaMoradi
Copy link
Member

@AriaMoradi AriaMoradi commented Nov 15, 2021

Critically breaking change on users side, maybe having some migration method is desired?
Opinions please.

@AriaMoradi AriaMoradi requested review from ntbm and Syer10 November 15, 2021 09:07
@Syer10
Copy link
Collaborator

Syer10 commented Nov 15, 2021

Personally redownloading covers would be fine. We could make a quick migration that deletes the original folder or renames it. I would suggest storing that we have done the migration in the preferences or somewhere.

@AriaMoradi
Copy link
Member Author

We can try to do the migration on startup, then remove the code for migration on the next major release.

@AriaMoradi AriaMoradi merged commit bd96099 into master Nov 15, 2021
@AriaMoradi AriaMoradi deleted the anime-cleanup branch November 15, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants