Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Error handling for popular/latest api if pageNum was supplied as zero #424

Merged
merged 3 commits into from
Oct 28, 2022

Conversation

meta-boy
Copy link
Contributor

fixes #75

@meta-boy meta-boy changed the title Fix: Error handling for populare/latest api if pageNum was supplied as zero Fix: Error handling for popular/latest api if pageNum was supplied as zero Oct 24, 2022
@meta-boy meta-boy requested a review from Syer10 October 24, 2022 16:37
Copy link
Member

@AriaMoradi AriaMoradi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idiomatic kotlin solution. 👏

@meta-boy meta-boy requested a review from AriaMoradi October 26, 2022 09:49
@AriaMoradi AriaMoradi merged commit 6d88d90 into Suwayomi:master Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Requesting page 0 for popular/latest should throw an error
3 participants