Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/make config settings changeable during runtime #545

Conversation

schroda
Copy link
Collaborator

@schroda schroda commented May 7, 2023

No description provided.

@Syer10
Copy link
Collaborator

Syer10 commented May 7, 2023

What happens to the comments, ordering, newlines, and such when editing the file. Are they preserved?

@schroda
Copy link
Collaborator Author

schroda commented May 7, 2023

What happens to the comments, ordering, newlines, and such when editing the file. Are they preserved?

yes, that is done by ConfigDocument

@schroda schroda force-pushed the feature/make_config_settings_changeable_during_runtime branch from a789164 to 9176d62 Compare May 10, 2023 17:37
@schroda schroda marked this pull request as ready for review May 10, 2023 17:38
@schroda schroda force-pushed the feature/make_config_settings_changeable_during_runtime branch from 9176d62 to 7edf450 Compare May 10, 2023 17:41
@schroda schroda closed this May 10, 2023
@schroda schroda reopened this May 10, 2023
@AriaMoradi AriaMoradi merged commit 51bfdc0 into Suwayomi:master Jun 5, 2023
@schroda schroda deleted the feature/make_config_settings_changeable_during_runtime branch June 9, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants