Correctly check for existing download when downloading a chapter #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schroda
force-pushed
the
fix/handling_of_already_existing_cbz_chapter_downloads
branch
from
c7ce367 to
03fcd47
Compare
schroda
force-pushed
the
fix/handling_of_already_existing_cbz_chapter_downloads
branch
from
03fcd47 to
82364cb
Compare
schroda
changed the title
schroda
force-pushed
the
fix/handling_of_already_existing_cbz_chapter_downloads
branch
from
82364cb to
3a2e724
Compare
In case a chapter is marked as not downloaded, but the download folder exists already, the chapter did not get downloaded again. This could cause issues in case the previous download failed or has missing pages. Instead of only checking if the folder exists, each page should be checked individually This was previously done and was incorrectly changed with 1c9a139.
schroda
force-pushed
the
fix/handling_of_already_existing_cbz_chapter_downloads
branch
from
3a2e724 to
5b5a444
Compare
Syer10
approved these changes
Nov 4, 2023
schroda
deleted the
fix/handling_of_already_existing_cbz_chapter_downloads
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for all downloaded pages during a chapter download
In case a chapter is marked as not downloaded, but the download folder exists already, the chapter did not get downloaded again.
This could cause issues in case the previous download failed or has missing pages.
Instead of only checking if the folder exists, each page should be checked individually
This was previously done and was incorrectly changed with 1c9a139.