Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup #117

Merged
merged 2 commits into from
Dec 19, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<--!
<!--
Pull Request Checklist:
- Mention what the pull request does and the rational behind the changes
- Include enough before and after images if there are visual changes
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@ import React, { useState, useEffect } from 'react';
import { Box, styled } from '@mui/system';
import { Virtuoso } from 'react-virtuoso';
import Typography from '@mui/material/Typography';
import ChapterCard from 'components/ChapterCard';
import { CircularProgress, Fab } from '@mui/material';
import { Link } from 'react-router-dom';
import makeToast from 'components/util/Toast';
import client from 'util/client';
import PlayArrow from '@mui/icons-material/PlayArrow';
import ChapterOptions from 'components/ChapterOptions';
import useLocalStorage from '../util/useLocalStorage';
import ChapterOptions from 'components/chapter/ChapterOptions';
import ChapterCard from 'components/chapter/ChapterCard';
import useLocalStorage from 'util/useLocalStorage';

const List = styled(Virtuoso)(({ theme }) => ({
listStyle: 'none',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ interface IProps{
setOptions: React.Dispatch<React.SetStateAction<ChapterListOptions>>
}

const SortTab: [SortMode, string][] = [['source', 'By Source'], ['fetchedAt', 'By Fetch date']];
const SortTab: [ChapterSortMode, string][] = [['source', 'By Source'], ['fetchedAt', 'By Fetch date']];

export default function ChapterOptions(props: IProps) {
const { options, setOptions } = props;
Expand Down Expand Up @@ -48,7 +48,7 @@ export default function ChapterOptions(props: IProps) {
setOptions({ ...options, active, bookmarked: newBookmarked });
};

const setSort = (newSort: SortMode) => {
const setSort = (newSort: ChapterSortMode) => {
if (newSort !== options.sortBy) {
setOptions({ ...options, sortBy: newSort });
} else {
Expand Down
2 changes: 1 addition & 1 deletion src/screens/Manga.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import MangaDetails from 'components/MangaDetails';
import NavbarContext from 'components/context/NavbarContext';
import client from 'util/client';
import LoadingPlaceholder from 'components/util/LoadingPlaceholder';
import ChapterList from 'components/ChapterList';
import ChapterList from 'components/chapter/ChapterList';
import { useParams } from 'react-router-dom';

export default function Manga() {
Expand Down
4 changes: 2 additions & 2 deletions src/typings.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -219,14 +219,14 @@ interface PaginatedList<T> {

type NullAndUndefined<T> = T | null | undefined;

type SortMode = 'fetchedAt' | 'source';
type ChapterSortMode = 'fetchedAt' | 'source';

interface ChapterListOptions {
active: boolean
unread: NullAndUndefined<boolean>
downloaded: NullAndUndefined<boolean>
bookmarked: NullAndUndefined<boolean>
reverse: boolean
sortBy: SortMode
sortBy: ChapterSortMode
showChapterNumber: boolean
}