Show empty library in case search doesn't match anything #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akabhirav
reviewed
Feb 27, 2023
| return filteredManga; | ||
| }; | ||
| ): IMangaCard[] => | ||
| performSearch(query, manga).filter((m) => downloadedFilter(downloaded, m) && unreadFilter(unread, m)); |
There was a problem hiding this comment.
filtering the manga, before calling performSearch should increase the performance for large libraries
There was a problem hiding this comment.
you're right it's not optimal currently.
I think the best way should be to perform search and filter on each manga in one go.
I'll open a new pr for that
There was a problem hiding this comment.
nervermind, changed it in this pr
akabhirav
reviewed
Feb 27, 2023
| return filteredManga; | ||
| }; | ||
| ): IMangaCard[] => | ||
| performSearch(query, manga).filter((m) => downloadedFilter(downloaded, m) && unreadFilter(unread, m)); |
There was a problem hiding this comment.
Suggested change
| performSearch(query, manga).filter((m) => downloadedFilter(downloaded, m) && unreadFilter(unread, m)); | |
| performSearch(query, manga.filter((m) => downloadedFilter(downloaded, m) && unreadFilter(unread, m))); |
something like this
In case the search didn't match anything all mangas where shown instead of an empty library.
Makes it easier to read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the search didn't match anything all mangas where shown instead of an empty library.