Update to BUILDING.md #420
Conversation
skrewde
commented
Sep 22, 2023
•
skrewde
commented
- Correct typos.
- Edit lines ensuring a consistent tense and pacing.
- Tweak spacing and script notes.
* Corrected typos. * Edited lines to ensure a consistent tense and pacing. * Tweaked spacing and script notes.
|
|
||
| See the section about [Building for Production](https://vitejs.dev/guide/build.html) for more information. | ||
| ### `yarn build` |
There was a problem hiding this comment.
I think it would be best to just change it to something like
This command creates an optimized production build and places it in the `build` folder.
See this section about [Building for Production](https://vitejs.dev/guide/build.html) for more information.
There was a problem hiding this comment.
I agree. I was unsure of the OP's intent so I kept the lines.
Edit: Also edited my commit message to reflect present tense. Read a post on best (commit) practices and I'm trying to adhere to them.
There was a problem hiding this comment.
last thing, command optimizes the production build makes it sound like it's optimizing an existing build, but it creates the optimized production build
There was a problem hiding this comment.
Missed the notification for this. Please let me know if the change I just made is sufficient.
Also, is there a better way to contact you? Discord maybe?
There was a problem hiding this comment.
you can join the server https://discord.gg/DDZdqZWaHA
