Make reader width configurable #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancez
force-pushed
the
pr/chancez/configurable_reader_width
branch
from
71b57e8 to
37e3398
Compare
|
the setting does nothing in case "Fit page to window" is enabled or the "double page" or "vertical reader" is selected, so it would be best to hide it in these cases |
Is that the same as the conditions for |
|
yeah, something like that |
chancez
force-pushed
the
pr/chancez/configurable_reader_width
branch
from
37e3398 to
a110a2e
Compare
|
@schroda Ok, did a few updates, let me know what you think. |
schroda
reviewed
Jan 21, 2024
chancez
force-pushed
the
pr/chancez/configurable_reader_width
branch
2 times, most recently
from
8d7d4c3 to
2077671
Compare
schroda
reviewed
Jan 21, 2024
chancez
force-pushed
the
pr/chancez/configurable_reader_width
branch
from
2077671 to
ce594ae
Compare
schroda
approved these changes
Jan 21, 2024
Signed-off-by: Chance Zibolski <[email protected]>
chancez
force-pushed
the
pr/chancez/configurable_reader_width
branch
from
ce594ae to
a729b88
Compare
|
Fixed CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new setting to configure the reader width.
One unrelated change is I changed the adornment for NumberSetting from
startAdornmenttoendAdornment. Having the unit (%) in the front looked weird. I checked this effected other settings using the component and IMO it looked better as an endAdornment in all cases, but glad to make this a configurable property if that's preferred.