Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI changes in Filter images screen #185

Closed
Swati4star opened this issue Jul 9, 2018 · 11 comments · Fixed by #211
Closed

UI changes in Filter images screen #185

Swati4star opened this issue Jul 9, 2018 · 11 comments · Fixed by #211

Comments

@Swati4star
Copy link
Owner

Swati4star commented Jul 9, 2018

Currently, the filter images screen looks like this:
screen shot 2018-07-09 at 11 38 51 am

Make following enhancements to it:

  • Add a greyish background color to bottom strip
  • Change the filter icons (None, Sepia, Black & white) to look like this:
    img_20180709_114657
    (Use any sample image of a flower & show it on none, sepia & black-white icons below in circular images, & write the name of effect below those images)
  • Change the backgroung color of Save Current button to orange (our app's color) & text color to white
  • Change the right arrow icon to something which doesn't have greyish background.
  • In the action bar, change the done text to tick mark icon
  • Use two way list view to add filters in the bottom strip (so that it becomes easier to add more filters )
@Sabihashaik
Copy link
Contributor

@Swati4star I would like to work on this issue.
Can you clarify what you mean by the Two way list view?

@Swati4star
Copy link
Owner Author

I was actually referring to this one : https://github.com/lucasr/twoway-view
(But this repository seems to be archived now)
The purpose of this was horizontal list view.

I think we can create horizontal list view using recycler view also. So, you may use that only.

@Sabihashaik
Copy link
Contributor

@Swati4star Ok, So something such as this? Horizontal list view using Recycler view

@Swati4star
Copy link
Owner Author

Yes @Sabihashaik 👍

@Swati4star
Copy link
Owner Author

@Sabihashaik Any updates?

@Sabihashaik
Copy link
Contributor

Yes. Working on it. Will send a PR quite soon.

@Sabihashaik
Copy link
Contributor

@Swati4star I have a question, I have set everything up, a Recycler View with circle images and such. However, I'm facing a problem when trying to access my previously made functions (None filter, Sepia etc) through which position is being clicked.
I'm checking which position is being clicked in a new class called RecyclerViewAdapter and then passing the value to PhotoEditor class where I have a function to match the position with the corresponding filter function.
Also, Here is a screenshot of the updated layout.
updated layout

@Swati4star
Copy link
Owner Author

@Sabihashaik

  • Change the color of arrow from black to white
  • I didn't exactly get your problem. Are you not able to get the position of item clicked?

Also, UI looks good now.

@Sabihashaik
Copy link
Contributor

Sabihashaik commented Jul 13, 2018

@Swati4star I'm able to get the position of the item being clicked, but not able to set the Image View with the new image once clicked.
It shows a null pointer exception when I try to set it from the Recycler View Adapter, like if item position is 0, I call the none filter function from photo editor class but it returns a null pointer exception.

Googling seems like I have to set up an interface seperately to handle callbacks?

Sure, I'll change the color of arrow.

@Swati4star
Copy link
Owner Author

What you can do it...

@Sabihashaik
Copy link
Contributor

@Swati4star Thank you! That works! :)

NegassaB added a commit to NegassaB/Images-to-PDF that referenced this issue Feb 19, 2019
* Swati4star#185 - UI changes in `Filter images` screen (Swati4star#211)

* Code refactoring; added new model for filter item

* Swati4star#177 - Text To PDF feature (Swati4star#219)

* Swati4star#215 - UI changes in View Files fragment (Swati4star#225)

* Swati4star#224 - action to text-pdf Snackbar (Swati4star#226)

* Swati4star#213 - Create PDF button is disabled even when an image is selected (Swati4star#228)

* Swati4star#157 - Button instead of textview in ViewFiles (Swati4star#230)

* Swati4star#229 - disable create PDF when no image is selected (Swati4star#231)

* Swati4star#221 - Added textview to show selected text file name (Swati4star#232)

* Swati4star#216 - Show previous image button also in filter image screen (Swati4star#233)

* Swati4star#223 - Enhancement options in text to pdf (Swati4star#236)

* Swati4star#212 - change icons for view files & compress image (Swati4star#237)

* Swati4star#238 - Fixed file name overwritten in text to PDF (Swati4star#239)

* code refactoring

* Swati4star#240 - App crashes if we don't provide font size (Swati4star#244)

* Swati4star#241 - Snackbar is shown even if we don't select any file (Swati4star#245)

* Swati4star#242 - Few UI changes (Swati4star#246)

*  Swati4star#196 - Code cleanup, created PDFOptions class (Swati4star#249)

* updated Gif in readme (Swati4star#252)

* Swati4star#243 - added "set default font size" feature. (Swati4star#253)

*  Swati4star#162 - Added About us Screen (Swati4star#254)

* Swati4star#88 - option to preview images (Swati4star#255)

* code cleanup

*  Swati4star#234 - Added more filters (Swati4star#258)

* remove circular image library; added our own utility function for circular image; code refactoring in image filters; removed border from image by default (fixes 251

* playstore update [5.0.0 ; v17]

* Swati4star#256 - Fixed Default size updated (Swati4star#261)

* fixes Swati4star#247 - incorrect text file name was getting displayed

*  Swati4star#260 - View Files UI Fix (Swati4star#264)

* Swati4star#137 - Added conversion history module (Swati4star#266)

* Improving performance; Removed unused resources (Swati4star#267)

* reducing code complexity

* Swati4star#153 - Removed extra TextView in MergeFiles (Swati4star#270)

* improving code climate

* Swati4star#259 - Fixing the view styles screen in case of empty list (Swati4star#271)

* Swati4star#263 -  select font family in text to PDF (Swati4star#272)

* Swati4star#262 - Changes in preview screen (Swati4star#274)

* creating new utils files, as there was a lot in fileutils.java

* Swati4star#218 - Adding back button & cancel option filter screen (Swati4star#279)

* Swati4star#89 - option to rearrange the images selected in preview screen (Swati4star#278)

* Swati4star#283 - Open PDF files when it is selected in history section (Swati4star#286)

* Swati4star#276 - Added undo option in delete snackbar(Swati4star#287)

* Cleaning up Image to pdf fragment

* fixes Swati4star#291 - provide support for java 8 features

* Removing extra views

* Swati4star#289 - updating images in preview screen(Swati4star#292)

* Swati4star#290 - UI changes in preview screen (Swati4star#295)

* Swati4star#275 - Search fix (Swati4star#296)

* playstore update v18:6.0.0

* Swati4star#284 -  Double click fix on select images (Swati4star#297)

* Update README.md

* Changed slack invite link

* Swati4star#294 - UI changes in image rearrange screen (Swati4star#303)

* Swati4star#299 - Reversed the files order in history section. (Swati4star#304)

* Swati4star#301 - Show image name at the bottom in preview images (Swati4star#305)

* Update README.md

* Swati4star#293 - Fixed Empty view is still there after undoing delete (Swati4star#307)

* minor changes

*  Swati4star#309 - Fixed History date format (Swati4star#310)

* Swati4star#268 - Fragment Transitions (Swati4star#312)

* Update README.md

* Update README.md

* Swati4star#306 - Edit Images doesn't work after selecting filter images. (Swati4star#315)

*  Swati4star#313 - Few issues in filter screen (Swati4star#316)

* Swati4star#300 - Fixed the filtered image name always contains sepia (Swati4star#317)

* Fixing crash in history section for old files

* show error message when no pdf selected in merge PDF

* Swati4star#308 - Added reset button in the filter screen to undo saved changes. (Swati4star#318)

* Few layout changes

* Swati4star#302 - added "Set Page Size" option in Text to Pdf (Swati4star#319)

* Update README.md

* Update README.md

* Swati4star#257 - added "Sort" option in Preview Images. (Swati4star#322)

* Swati4star#320 - Show Lock image icon for encrypted pdfs (Swati4star#323)

* Swati4star#281 - Show animation in merge PDF (Swati4star#324)

* Swati4star#298 - fixing the Fragment is not getting highlighted in few cases(Swati4star#325)

* Swati4star#277 - View Files in Merge pdf section. (Swati4star#327)

* Swati4star#165 - Added doodle option to images (Swati4star#328)

* minor changes

* Swati4star#329 - UI Changes 'View Files' in Merge Pdf Fragment. (Swati4star#338)

* Swati4star#332 - Shown 'View' action in Snackbar in Merge PDF (Swati4star#337)

* Swati4star#333 - Change button color in `Merge PDF` (Swati4star#336)

* Swati4star#321 - Back button on any navigation bar activity closes the app (Swati4star#341)

* Swati4star#330 - Hide the `View Files` option in Merge PDF, when there are no files. (Swati4star#339)

* Swati4star#331 - Disabled the Create Pdf button and Enabled it after file selection (Swati4star#340)

* Swati4star#280 - Disabled the Merge Files button and Enabled it after file selections. (Swati4star#342)

* Swati4star#343 - Changed rename record database entry, from oldname to new name(Swati4star#349)

* Remove Circle CI

* Fixing fragment stacking issue

* Swati4star#350 -  Fixed issue 'Files are getting Overwritten while renaming the file'.(Swati4star#355)

* Swati4star#351 - reset everything to initial stage after pdf creation (Swati4star#357)

* Swati4star#352 - reset to initial stage after pdf creation in Text to pdf (Swati4star#358)

* Swati4star#356 - Implemented Persistent Bottom Sheet in View Files Merge pdf Fragment (Swati4star#359)

* few minor changes

* Swati4star#282, Swati4star#360 - Fix invalid file error in case PDFs cant merge

* Swati4star#348 - Changed "Save Current Images First" toast showing logic (Swati4star#362)

* Swati4star#354 - Added Password Protection option in Text to PDF (Swati4star#363)

* Swati4star#353 - Fixed Set Page Size value is not retaining (Swati4star#366)

* Fixed crash in Merge Files & view files (in case permissions are not given)

* Refactored merge fragmnent module. Also, Fixed Swati4star#334: Doodle button color change issue

* Changes in doodle effect ui fixes Swati4star#335, fixes Swati4star#347

* Fixed reset button issue

* fixes Swati4star#33 - Add option to add border around images

* Moved brushes to an adapter

* Fixed crash when share app is selected; Hiding empty view by default in history fragment
fixes Swati4star#370 -  text is not visible when images are selected

* Fixed compression issue (images were not getting compressed); added more color to brushes

* Remove unused resources

* Swati4star#345 ,Swati4star#369 - Bugs in edit images & filter images (Swati4star#375)

* Removed redundant code

* Swati4star#373 - Hide arrow icon when there is just one image (Swati4star#376)

* Compression issue

* Swati4star#364 - Fixed text & size of `create PDF` button on home page (Swati4star#377)

* updated readme with new features (Swati4star#378)

* Improve code climate

* fixes Swati4star#90 - New feature : Add option to extract images from PDF

* updated buy me a coffee link

* fixed flickering issue in merge files fragment; back pressed issue

* Swati4star#214 - Added 'set as default' option in Page Size dialog (Swati4star#382)

* fixing output filename bug

* Swati4star#384 - fixed bug in filter images screen (Swati4star#385)

* Swati4star#374 - removed alert if no filters are applied on home click (Swati4star#387)

filter screen

* Swati4star#344 - added warning dialog if filter is not saved on finish click(Swati4star#386)

filter screen

* Fixed crash; changed few code pieces

* Swati4star#380 - Added an option to remove image in rearrange screen. (Swati4star#391)

* fixes Swati4star#388 - Disable extract images button when no PDF is selected
Removed duplicate code
added a placeholder for watermark options

* fixes Swati4star#148 - add adaptive icon support

* Swati4star#365 - Removed Random file selection behaviour in view files fragment (Swati4star#394)

* Refactore fileuriutils

* Swati4star#372 - Show lock icon if PDF is encrypted [Merge PDF - View Files] (Swati4star#398)

* Swati4star#91 - add option to split PDF

* Added rate us dialog; Added icons in history section; fixes Swati4star#383 - show extracted images
added option to remove pages from pdf

* Swati4star#371 - Fixed 'Files get overwritten if existing name is given' Merge Files Fragment(Swati4star#401)

* Swati4star#400 - Added option to rotate pages in existing PDFs(Swati4star#402)

* fixes Swati4star#403 - added more operations to history database
fixes Swati4star#399 - allow users to reorder PDF
fixing few cashes reported

* fixes Swati4star#405 - sorting order messes up

* fixes Swati4star#381 - [Image Border] Add  option

* Swati4star#389 - Shown animation while extracting images - Extract Image Fragment. (Swati4star#406)

* Removing completely white images from extract images

* Swati4star#395 - Added an option to share extracted images (Swati4star#408)

* fixes Swati4star#410 - show thumbnail of extracted image; fixes Swati4star#407 - update view when delete undo is clicked

* fixes Swati4star#379 - add option to compress PDF; added option to rearragne images in home screen

* Swati4star#404 - Added an option to add multiple files in Merge PDF Fragment.(Swati4star#411)

* showing how much pdf is compressed; changed button color to blue, instead of grey
removed code duplicacy

* fixed issue with pdf encryption
added specific angles for rotation

* Swati4star#412 - Bug fixed of home scrolling down (Swati4star#414)

* Add settings page (Swati4star#419)

* removed extra code from settings fragment

* Swati4star#367 - Fixed permission error in [Text to PDF] Fragment (Swati4star#421)

* using matisse activity; instead of tedpicker; reason: tedpicker doesn't allow selection of folders (Swati4star#422)

* removed extra code

* Fix overlap between text and button in empty history view (Swati4star#423)

* fixed few static leaks; fixed string errors

* fixes Swati4star#326 - allow users to customize storage location

* fixes Swati4star#368 - show no permissions view in view files

* Swati4star#147 - Added app shortcuts for Android 7.0 and up (Swati4star#424)

* code cleanup
removed redundant code

* fixed file path issue

* fixed a few crashes

* showing all pdf files in bottom sheet; moved common code to bottomsheetutils

* moved common code to utils

* fixed crash

* Moved population of bottomsheet to async task

* files were getting displayed twice in the list

* Swati4star#393 - create a Home Page (Swati4star#426)

* fixes Swati4star#425 - add option to view extracted images

* fixes Swati4star#390 - changes image names in extract images

* added android arsenal link to readme

* Swati4star#361 -  Add custom toolbar when PDFs are selected (Swati4star#428)

* Fix bug, when selected null file(crash, when selected all pressed) (Swati4star#430)

* Swati4star#138 - Add option to create grayscale pdf (Swati4star#429)

* hiding the file select count when view files fragment is closed

* Swati4star#432 - Allow users to reorder the sequence of PDFs in merged PDF  (Swati4star#435)

* Swati4star#145 - Add themes to the app (Swati4star#434)

* History icon & toolbar icon fixed in different themes (Swati4star#436)

* Divider color fixed, bottom sheet fixed, unnecessary themes and colors deleted. (Swati4star#437)

*  Swati4star#427 - [New Feature] Allow users to scan QR code (Swati4star#439)

* made few changes in theme; removed unused imports

* removed unused icons

* removed unused icons

* updating version

* Add different themes to readme (Swati4star#448)

* Update README.md (Swati4star#449)

* Swati4star#447 - add preview of pdf page in reorder/remove pdf pages (Swati4star#450)

* Update README.md (Swati4star#451)

* fixed few issues in reorder PDF

* Swati4star#452 -  Few issues in Bottom sheet (Swati4star#455)

* Swati4star#453 - highlighting correct fragment (Swati4star#457)

* Swati4star#396 - Added an option to encrypt PDF - Merge PDF (Swati4star#459)

* Swati4star#443 - Add margins (Swati4star#461)

* 132 - Unit tests for file utils class(Swati4star#464)

* Swati4star#458 - Merge PDF button remains white after File selection (Swati4star#462)

* Swati4star#108 - Add a basic tutorial to explain the functioning of app (Swati4star#465)

* Made few changes in Welcome activity; removed constant strings; add help section in app

* Swati4star#460 - add animation to upArrow when sliding/hiding bottom sheet in fragments (Swati4star#466)

* Swati4star#456 - replaced fetching text with lottie progress (Swati4star#463)

* Swati4star#444 - Remove pages issue with external storage (Swati4star#469)

* Swati4star#473 - smooth scrolling (Swati4star#474)

* few chnages in qr code scanning

* few playstore reported crash fixes (Swati4star#475)

* Swati4star#472 - add scaleToFit; fixes margins issue (Swati4star#476)

* removed unused maven repo
fixing android.view.ViewRootImpl exception
remove unused variables

* Swati4star#470 - Add Get Started button on last fragment in WelcomeActivity (Swati4star#478)

* update v61
fixed an issue with bottomsheet

*  Swati4star#479 - Fixing checkbox state in View Files fragment (Swati4star#481)

* fixed crashes; remove unused resources (Swati4star#483)

* Swati4star#482 - added view pdf button (Swati4star#484)

* version update; fixed crash in remove pages; fixed background task issue in bottomsheet

* Swati4star#442 - added fdroid-badge (Swati4star#486)

* fixes Swati4star#485 - add an  option to maintain aspect ratio/stretch image (Swati4star#488)

* Update README.md (Swati4star#491)

* Swati4star#489 - Lock icon color in view files (Swati4star#492)

* Swati4star#440 - Add Merge PDF option (Swati4star#493)

* Swati4star#441 - Add `Remove password` and `Add password` option in navigation drawer (Swati4star#498)

* Swati4star#495 - added FAQs.md (Swati4star#497)

* incorporate theme colors in imageeditor activity

* Add translation to Russian language (Swati4star#504)

* Swati4star#499 - Add new feature - Converting PDF pages to images (Swati4star#505)

* Swati4star#502 - Added image cropper in own custom activity (Swati4star#506)

* Swati4star#507 - Add a previous button in image cropper activity (Swati4star#508)

* PDF from camera image, closes Swati4star#510

* [PDF enhancement options] Add page number of PDF Swati4star#446

* fixes Swati4star#515 - create grayscale PDF, page num issues, ui fixes

* fixed few playstore crashes

* Swati4star#513 - change master pwd, remove directory operations in view files, decrypt pdf by master pwd (Swati4star#517)

* fixes Swati4star#441 - moved add & remove password to new fragment:

* Swati4star#516 - whatsnewfragment-feature (Swati4star#518)

* Swati4star#392 - added watermark class and add_watermark_dialog.xml, added Add watermark option to the home page and ImagesToPdf page, added mentioned option to View files page (Swati4star#520)

* increased build num; updated whatsnew

* Swati4star#248 - add possibility to create pdf file also from .doc and .docx files (Swati4star#522)

* Swati4star#431 - chceckbox added before each file in merge files fragment (Swati4star#521)

* update 74

* fixed few playstore reported crashes

* Swati4star#523 - Add sorting option under Rearrange images (Swati4star#525)

* Swati4star#526 - Few fixes in spanish translation (Swati4star#528)

* few playstore reported bugs & Swati4star#527 (Swati4star#531)

* fix Swati4star#413 - add images to existing PDF (Swati4star#532)

* fixes Swati4star#541 - rotate pages show watermark dialog also

* fixes Swati4star#540 - Font size does not work unless set to default

* fixes Swati4star#529 - sharing images using third party apps; removed unused resources

* Swati4star#533 - changes in cropimage activity (Swati4star#544)

* bug fixes in remove pages fragment

* Swati4star#538 - Update to Spanish (ES) translation to strings.xml (Swati4star#546)

* Swati4star#514 - add remove duplicate feature (Swati4star#547)

* fixed few bugs; new screenshots; some changes in home screen (Swati4star#550)

* update version, code cleanup and fixed error in convert pdf pages to image

* fixes Swati4star#551 -  issue with pdf to image

* Swati4star#534 - Fixed issue with password added without OK click (Swati4star#556)

* Swati4star#557 - remove overlapping of date and type textviews (Swati4star#558)

* Swati4star#512 - add invert pdf feature (Swati4star#560)

* Swati4star#494 - Fixed search files animation looks in different themes (Swati4star#566)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants