Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write unit test for calculateFitSize method in ImageUtils #598

Closed
dr0pdb opened this issue Mar 6, 2019 · 3 comments · Fixed by #620
Closed

Write unit test for calculateFitSize method in ImageUtils #598

dr0pdb opened this issue Mar 6, 2019 · 3 comments · Fixed by #620
Labels
easy gssoc19 in progress

Comments

@dr0pdb
Copy link

dr0pdb commented Mar 6, 2019

The calculateFitSize method in ImageUtils is untested. It would be great if unit tests could be added with various test cases in order to test if the method works as expected.

Please write tests for the method with various input arguments.
@jddeep
Copy link
Contributor

jddeep commented Mar 10, 2019

@Swati4star @srv-twry I would like to work on it. Can I proceed?

@jddeep
Copy link
Contributor

jddeep commented Mar 10, 2019

@Swati4star I would take a look at #549 at a little later time. As I am a bit short on time now. The issue #549 remains open btw and if someone other wants can claim it in the mean time. Thank you.

@Swati4star
Copy link
Owner

Sure @jddeep 👍

@jddeep jddeep mentioned this issue Mar 11, 2019
Merged
9 tasks
Swati4star pushed a commit that referenced this issue Mar 14, 2019
@jddeep @Swati4star
#598 - Added unit test for calculate fit size (#620)
ee957d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy gssoc19 in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added unit test for calculate fit size jddeep/Images-to-PDF
3 participants
@Swati4star @dr0pdb @jddeep