Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Option in View files #467

Closed
wants to merge 1 commit into from
Closed

Conversation

prajwal27
Copy link

Look into the code for the changes made!
tried to resolve the issue #440

@codeclimate
Copy link

codeclimate bot commented Oct 6, 2018

Code Climate has analyzed commit 580464c and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

View more on Code Climate.

Copy link
Owner

@Swati4star Swati4star left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have reverted the changes for a lot of other features, please loook into that.
Also, the checks are failing..

@@ -17,4 +17,3 @@ script:
- chmod +x ./gradlew
- ./gradlew assembleDebug assembleRelease
- ./gradlew checkstyle
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why made changes here?

@Swati4star
Copy link
Owner

Issue has been closed by another PR. You didn't respond to this.

@Swati4star Swati4star closed this Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants