Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Merge option #487

Closed
wants to merge 3 commits into from

Conversation

sandraprog
Copy link
Contributor

Description

Add Merge PDF option in View Files

Fixes #440

Type of change

Just put an x in the [] which are valid.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • ./gradlew assembleDebug assembleRelease
  • ./gradlew checkstyle

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codeclimate
Copy link

codeclimate bot commented Oct 10, 2018

Code Climate has analyzed commit 4387f7d and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 4

View more on Code Climate.

* Merge the selected PDFs into a single PDF
* Show a dialog to allow user to enter file name
*/
void mergeFiles() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file already is quite big & has a lot of utilities. You can add it option in any existing file in utils package, or create a new one.

@sandraprog sandraprog closed this Oct 11, 2018
@sandraprog sandraprog deleted the 440-add-merge-option branch October 11, 2018 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Merge PDF option in View Files
2 participants