Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

420 add splitting options #567

Merged
merged 9 commits into from
Feb 22, 2019

Conversation

Shivamdhuria
Copy link
Contributor

@Shivamdhuria Shivamdhuria commented Feb 20, 2019

Description

Added an Edittext which fills in value automatically on selection for single page PDFs.Changing the edit text can help create any configuration of PDFs.
screenshot_1550758135

Fixes #420

Type of change

Just put an x in the [] which are valid.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • ./gradlew assembleDebug assembleRelease
  • ./gradlew checkstyle

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
    screenshot_1550758135

@codeclimate
Copy link

codeclimate bot commented Feb 20, 2019

Code Climate has analyzed commit ddb7a8d and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2

View more on Code Climate.

@Swati4star
Copy link
Owner

Hi, please add screenshots also.

@Shivamdhuria
Copy link
Contributor Author

Shivamdhuria commented Feb 21, 2019

Hi, please add screenshots also.

Sure,added!
Edit - I forgot to add validation for the edit text,(app crashes if edittext string is in wrong format).I'll rectify that once you give me a go ahead with this implementation.

@Swati4star Swati4star merged commit e81f807 into Swati4star:master Feb 22, 2019
@Swati4star
Copy link
Owner

Hi @Shivamdhuria
You can add validation in another PR.

Swati4star pushed a commit that referenced this pull request Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Split PDF] Allow random file splitting
2 participants